add initialization example script #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test-all] |
phracek
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Container tests are passing. Unfortunately, I am not a database expert. @hhorak @fila43 WDYT?
As soon as @fila43 or @hhorak approve this pull request, we can merge it.
@aushacker Do we have a test for it? If not please create at least one.
|
@phracek Have had a look through the available tests, none of them seem to match the required procedure. What is needed to test would be something like:
How does that fit in with the current testing procedure? |
|
I do not see any problem with proposed example |
|
[test-all] |
|
@aushacker Thank you for this pull request. Please do following steps:
|
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple example showing how to configure a database with some test data.
When using ephemeral storage the database name specified by POSTGRESQL_DATABASE must be different from that created in the user provided script, otherwise the container will crash loop. This is due to the default scripts hard failing when trying to create a database that the user supplied init script has already created.
See issue #296 for narrative (known problem).